Skip to content

Commit

Permalink
Use cert-manager-app as service account name for Cert Manager (chan… (
Browse files Browse the repository at this point in the history
#269)

* Use `cert-manager-app` as service account name for Cert Manager (changed in recent version of cert-manager app).

* Use `cert-manager-app` as service account name for Cert Manager (changed in recent version of cert-manager app).

* bogus change to try and re-do the docker build
  • Loading branch information
Christian Bianchi authored Feb 28, 2024
1 parent b80dbf8 commit 17481d2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Use `cert-manager-app` as service account name for Cert Manager (changed in recent version of cert-manager-app).

## [0.15.0] - 2024-01-10

### Changed
Expand Down
2 changes: 1 addition & 1 deletion controllers/common_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ var certManagerRoleInfo = RoleInfo{
"Action": "sts:AssumeRoleWithWebIdentity",
"Condition": {
"StringEquals": {
"irsa.test.gaws.gigantic.io:sub": "system:serviceaccount:kube-system:cert-manager-controller"
"irsa.test.gaws.gigantic.io:sub": "system:serviceaccount:kube-system:cert-manager-app"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/iam/iam.go
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ func policyName(role string, clusterID string) string {

func getServiceAccount(role string) (string, error) {
if role == CertManagerRole {
return "cert-manager-controller", nil
return "cert-manager-app", nil
} else if role == IRSARole {
return "external-dns", nil
} else if role == Route53Role {
Expand Down

0 comments on commit 17481d2

Please sign in to comment.