generated from giantswarm/template-app
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding default config #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvddriesch
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! Just one question
anvddriesch
reviewed
Jul 4, 2024
anvddriesch
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Adds a simplified way to configure auth apps in the bundle.
There is a new
defaultConfig
section available in the Helm values, which can be used to provide essential details about Dex connectors and RBAC rules. Some additional configuration options for Dex are also supported. Everything else that is required to deploy the Auth bundle is retrieved automatically from existing configs.The
defaultConfgi
section has the following structure:More detailed configuration can be provided in the "standard"
apps
section if needed. In that case thedefaultConfig
section can be omitted.When both
defaultConfig
andapps
sections are present, they are merged together and theapps
section takes priority.Testing
Description on how auth-bundle can be tested.
Checklist
values.yaml
andvalues.schema.json
are valid.