-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blasfeo as reusable CMake package #17
Open
roversch
wants to merge
16
commits into
master
Choose a base branch
from
cmake
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@giaf I updated the PR (see above), please review and merge, or add comments. |
@giaf since we're doing pull requests now, any comments on this one? By the way, I wanted to fix the conflicts, but I can't, since you revoked my access since starting this PR. If you want, we can go over them together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been reading up on CMake packages, and as an exercise I rewrote the blasfeo CMake, based on the most current Makefile. You can use it as follows:
For ease of use, I also added the possibility for it to work with the CMake GUI and
ccmake
, with drop-down menus for the different choices of target, BLAS implementation etc.UPDATE:
-m64
for MKL and-std=c99
for BLIS)compile_definitions
instead of compiler flags leads to robuster builds