check for empty job connection

giacomomasseron · Dec 1, 2024 · bec9bac · bec9bac
1 parent ed91edd
commit bec9bac
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/packages/actions/src/Concerns/CanExportRecords.php b/packages/actions/src/Concerns/CanExportRecords.php
@@ -240,7 +240,10 @@ protected function setUp(): void
                 )
                 ->dispatch();
 
-            if (($jobConnection !== 'sync') || (blank($jobConnection) && (config('queue.default') !== 'sync'))) {
+            if (
+                (filled($jobConnection) && ($jobConnection !== 'sync')) ||
+                (blank($jobConnection) && (config('queue.default') !== 'sync'))
+            ) {
                 Notification::make()
                     ->title($action->getSuccessNotificationTitle())
                     ->body(trans_choice('filament-actions::export.notifications.started.body', $export->total_rows, [

diff --git a/packages/actions/src/Concerns/CanImportRecords.php b/packages/actions/src/Concerns/CanImportRecords.php
@@ -308,7 +308,8 @@ protected function setUp(): void
                             ]),
                         )
                         ->when(
-                            ($jobConnection === 'sync') || (blank($jobConnection) && (config('queue.default') === 'sync')),
+                            (filled($jobConnection) && ($jobConnection === 'sync')) ||
+                                (blank($jobConnection) && (config('queue.default') === 'sync')),
                             fn (Notification $notification) => $notification
                                 ->persistent()
                                 ->send(),
@@ -317,7 +318,10 @@ protected function setUp(): void
                 })
                 ->dispatch();
 
-            if (($jobConnection !== 'sync') || (blank($jobConnection) && (config('queue.default') !== 'sync'))) {
+            if (
+                (filled($jobConnection) && ($jobConnection !== 'sync')) ||
+                (blank($jobConnection) && (config('queue.default') !== 'sync'))
+            ) {
                 Notification::make()
                     ->title($action->getSuccessNotificationTitle())
                     ->body(trans_choice('filament-actions::import.notifications.started.body', $import->total_rows, [

diff --git a/packages/actions/src/Exports/Jobs/ExportCompletion.php b/packages/actions/src/Exports/Jobs/ExportCompletion.php
@@ -75,7 +75,8 @@ public function handle(): void
                 )),
             )
             ->when(
-                ($this->connection === 'sync') || (blank($this->connection) && (config('queue.default') === 'sync')),
+                (filled($this->connection) && ($this->connection === 'sync')) ||
+                    (blank($this->connection) && (config('queue.default') === 'sync')),
                 fn (Notification $notification) => $notification
                     ->persistent()
                     ->send(),