fix(engines): handle no engines case for merge #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalluban
force-pushed
the
fix-engines
branch
from
2139fcd to
1271a08
Compare
smalluban
force-pushed
the
fix-engines
branch
from
1271a08 to
8358d5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After all, there is a case where custom filters might need a
FIXES_ENGINEconfiguration - if you disable all of the features before you enable custom filters for the first time - otherwise, the config will be default, and then when turning on engines, the error of merging is thrown.Also, I realized that it might be a rare case, that for some reason all of engines won't initialize correctly, so the
engines.merge()function should cover that case.