Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc improvements #54

Closed
wants to merge 5 commits into from
Closed

Misc improvements #54

wants to merge 5 commits into from

Conversation

fillson-shady
Copy link
Collaborator

During a testing Coyote helped us a lot but we also faced some issues due to unreliable WiFi connection.
Once connection to a RabbitMQ cluster is interrupted subsequent messages will be lost.
Moreover upon restarting Coyote wipes an existing DB.

So I would like to contribute a couple of improvements:

  • if the DB already exists then do not recreate it
  • an option to make a persistent queue, so messages won't be lost if connection is interrupted
  • automatically try to reconnect if connection is interrupted

@ghokun ghokun self-requested a review September 3, 2024 12:57
@ghokun
Copy link
Owner

ghokun commented Sep 3, 2024

Changes are so nice! Is it possible to split them into different PR's? So I can rollback or revert to an older version in case there are regressions. In future I plan to extend test cases so it will not be a problem however now I do not trust my code :D

  1. Append to existing DB
  2. Add persistent option
  3. Auto reconnect on connection loss

@fillson-shady
Copy link
Collaborator Author

Sure, I'll create 3 separate PRs then 👍 Thank you for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants