Fix cnex to deal with certain Linux variations on time/clock handling. #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghewgill
requested changes
Jan 23, 2024
| @@ -1,6 +1,10 @@ | |||
| #define _POSIX_C_SOURCE 200809L | |||
| #include <stdlib.h> | |||
| #ifdef HAVE_CLOCK_GETTIME | |||
There was a problem hiding this comment.
This doesn't work. On a system that does have clock_gettime (and cmake detects so), this compiler define still isn't set. Cmake variables are not the same thing as compiler defines.
There was a problem hiding this comment.
Added define in CMakeLists.txt
gitlarryf
force-pushed
the
cnex-clock-gettime
branch
from
8f8ab61 to
34ce94f
Compare
ghewgill
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cnex to use gettimeofday() for those Linux implementations that don't support clock_gettime().