src/zfile.c: Use off_t instead of off64_t #1525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First discovered in while building on musl [1]. This is because musl-1.2.4 (9999 right now) will remove/removes the LFS compatibility hacks, like fopen64: - https://git.musl-libc.org/cgit/musl/commit/?id=246f1c811448f37a44b41cd8df8d0ef9736d95f4 - https://git.musl-libc.org/cgit/musl/commit/?id=25e6fee27f4a293728dd15b659170e7b9c7db9bc The gist is that bad configure tests (suffering from -Wimplicit-function-declaration) would build and link successfully because musl provided these symbols as aliases, despite not needing them (musl natively supports both LFS & time64). To head this off, these aliases are now gone, but remain in libc.so for binary compatibility. The proper fix is to just use the regular functions and not anything _LARGEFILE64_SOURCE As a temporary workaround you can typedef off_t to off64_t [2] to get it working. [1]: https://bugs.gentoo.org/908582 [2]: gentoo/gentoo#31186 Signed-off-by: Brahmajit Das <[email protected]>
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Oct 22, 2023
Apply the patch from [a PR][0] to the_silver_searcher. [0]:ggreer/the_silver_searcher#1525
|
This issue also occurs on DragonFly BSD. I found another way to fix it is to change |
|
@ggreer any plans on fixing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First discovered in while building on musl 1. This is because musl-1.2.4 (9999 right now) will remove/removes the LFS compatibility hacks, like fopen64:
The gist is that bad configure tests (suffering from -Wimplicit-function-declaration) would build and link successfully because musl provided these symbols as aliases, despite not needing them (musl natively supports both LFS & time64).
To head this off, these aliases are now gone, but remain in libc.so for binary compatibility.
The proper fix is to just use the regular functions and not anything _LARGEFILE64_SOURCE As a temporary workaround you can typedef off_t to off64_t 2 to get it working.
Signed-off-by: Brahmajit Das [email protected]