Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[d3d12] fix being able to use dispatchWorkgroupsIndirect without validation #6767

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[d3d12] fix being able to use dispatchWorkgroupsIndirect without validation #6767

merged 1 commit into from
Dec 17, 2024
+105 −74

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Dec 17, 2024

Follow-up to #5730 (which introduced the issue).

Trying to use dispatchWorkgroupsIndirect without the indirect-validation feature flag would result in:

Device creation failed: The parameter is incorrect. (0x80070057)

@teoxoy teoxoy requested a review from a team as a code owner December 17, 2024 12:23
@ErichDonGubler ErichDonGubler self-requested a review December 17, 2024 14:55
@ErichDonGubler ErichDonGubler added PR: needs back-porting PR with a fix that needs to land on crates type: bug Something isn't working area: correctness We're behaving incorrectly area: cts Issues stemming from the WebGPU Conformance Test Suite labels Dec 17, 2024
ErichDonGubler
ErichDonGubler approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual, LGTM, but with a question.

wgpu-core/src/device/resource.rs Outdated Show resolved Hide resolved
wgpu-hal/src/dx12/mod.rs Outdated Show resolved Hide resolved
@teoxoy teoxoy force-pushed the d3d12-fix-indirect-execution branch from 29a7214 to 095d3ac Compare December 17, 2024 15:22
@teoxoy teoxoy merged commit 04a1040 into gfx-rs:trunk Dec 17, 2024
27 checks passed
@teoxoy teoxoy deleted the d3d12-fix-indirect-execution branch December 17, 2024 16:10
@teoxoy
Copy link
Member Author

teoxoy commented Dec 17, 2024

I don't think we need to backport this since wgpu unconditionally enables the indirect-validation feature which works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler approved these changes

Assignees

@ErichDonGubler ErichDonGubler

@teoxoy teoxoy

Labels
area: correctness We're behaving incorrectly area: cts Issues stemming from the WebGPU Conformance Test Suite PR: needs back-porting PR with a fix that needs to land on crates type: bug Something isn't working
Projects
WebGPU for Firefox
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoxoy @ErichDonGubler