-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for the raytracing API #6747
Conversation
etc/ray_tracing.md
Outdated
`Committed`. | ||
- Calling `rayQueryProceed` when `rayQueryInitialize` has not previously been called on this ray query | ||
|
||
*this is only known undefined behaviour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section deliberately does not mention undefined behavior from #6752
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a style, formatting, and file-structure pass. Didn't change any of the content significantly, I think this is good to land!
looks good! |
Connections
Suggested by @cwfitzgerald on matrix
Description
Currently the raytracing API (especially in naga) is hard to find and and sometimes missing, this attempts to specify the naga API and to give some basics for how to use the wgpu API the users can follow up in the specific function's documentation.
This is correct to the best of my knowledge, but I may have missed something.
Testing
Docs change so no testing
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.