Move out invalidity from the Registry
#6243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r()` and use them for adapters This works because we never assign errors to adapters (they are never invalid).
This works because we never assign errors to surfaces (they are never invalid).
…rusty This is fine from the WebGPU spec's perspective as device creation returns a promise that can reject.
This works because we never assign errors to queues (they are never invalid).
This works because we never assign errors to devices (they are never invalid).
…of invalidity internalization)
teoxoy
force-pushed
the
move-out-invalidity
branch
from
60453fa to
ef6c48e
Compare
…buffers We now only rely on the presence of the inner `CommandBufferMutable` to determine if command buffers are invalid.
teoxoy
force-pushed
the
move-out-invalidity
branch
from
ef6c48e to
7ad4c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards #5121.
This moves out resource invalidity from the
Registry; by storing a newFallibletype in theRegistryinstead.Note that there are a few types that can't be invalid or have internal invalidity (ex
Device), those don't need to be wrapped in aFallible.PR doesn't need to be squashed, each commit builds by itself.