Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet more preempting of Rust 1.80 lints #6180

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Aug 28, 2024

Connections

Offloading some diff. complexity from #6105.

Description

Fixes more lints that will definitely affect us with Rust upgrades later.

Testing

Things still compile, so woot!

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file. Not necessary.

@ErichDonGubler ErichDonGubler added the area: infrastructure Testing, building, coordinating issues label Aug 28, 2024
@ErichDonGubler ErichDonGubler self-assigned this Aug 28, 2024
@ErichDonGubler ErichDonGubler requested a review from a team as a code owner August 28, 2024 18:08
@ErichDonGubler ErichDonGubler mentioned this pull request Aug 28, 2024
1 task
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-qsyqumqxtxxr branch from b3b3a34 to 1ee0bfe Compare August 28, 2024 18:11
@cwfitzgerald
Copy link
Member

What's the problem this is solving?

@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-qsyqumqxtxxr branch from c2e564a to 48eb02b Compare August 29, 2024 02:21
@ErichDonGubler
Copy link
Member Author

ErichDonGubler commented Aug 29, 2024

@cwfitzgerald:

What's the problem this is solving?

Individual motivations are already in the OP and individual commits, but to summarize: most of this changes code to add use std::mem::{size_of, size_of_val}, which is intended to head off most of the unused_qualifications warnings that will be introduced by Rust 1.80 adding them to the prelude. See also #6105.

@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-qsyqumqxtxxr branch 2 times, most recently from 9a31b72 to 54f8bb0 Compare August 29, 2024 02:49
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-qsyqumqxtxxr branch from 54f8bb0 to 12609ff Compare September 3, 2024 14:08
@ErichDonGubler ErichDonGubler enabled auto-merge (rebase) September 3, 2024 14:08
@ErichDonGubler ErichDonGubler merged commit 85346df into gfx-rs:trunk Sep 3, 2024
25 checks passed
@ErichDonGubler ErichDonGubler deleted the erichdongubler/push-qsyqumqxtxxr branch September 3, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infrastructure Testing, building, coordinating issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants