[naga] Implement subgroup quad ops #5684
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
approved these changes
May 29, 2024
teoxoy
requested changes
Jun 24, 2024
| @@ -1300,6 +1300,8 @@ pub enum GatherMode { | |||
| ShuffleUp(Handle<Expression>), | |||
| /// Each gathers from their lane xored with the given by the expression | |||
| ShuffleXor(Handle<Expression>), | |||
| /// All gather from the same lane at the index given by the expression | |||
| QuadBroadcast(Handle<Expression>), | |||
There was a problem hiding this comment.
In the proposal this expression needs to be a constant-expression due to a SPIR-V limitation.
Before version 1.5, Index must come from a constant instruction.
| @@ -1138,6 +1138,38 @@ impl super::Instruction { | |||
| } | |||
| instruction.add_operand(value); | |||
|
|
|||
| instruction | |||
| } | |||
| pub(super) fn group_non_uniform_quad_broadcast( | |||
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Partially solves #5555
Resolves #5670
https://github.com/gpuweb/gpuweb/blob/main/proposals/subgroups.md
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.