Fix x11 hang when resizing on vulkan #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
added a commit
that referenced
this pull request
Oct 3, 2023
Co-authored-by: Connor Fitzgerald <[email protected]>
wez
added a commit
to wez/wezterm
that referenced
this pull request
Oct 4, 2023
This picks up gfx-rs/wgpu#4184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Fixes #4180
Description
From @cwfitzgerald : The problem is that we actually don't have access to wait until presentation is finished. I suspect what is happening is that without the device.wait_idle() call whatever presentation things are happening are still in progress and calling device.wait_idle() is the only way to actually do that
Testing
Reproduced the steps in #4180, and everything resizes smoothly again