Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the metal dependency in hal instead of the workspace #4165

Closed
wants to merge 1 commit into from

Conversation

nical
Copy link
Contributor

@nical nical commented Sep 22, 2023

Connections

https://bugzilla.mozilla.org/show_bug.cgi?id=1854615

Description

Specifying the dependency at the workspace level does not appear to work with cargo vendor which Firefox uses.

@nical nical requested a review from a team as a code owner September 22, 2023 12:37
@fornwall
Copy link
Contributor

fornwall commented Sep 22, 2023

It (dependency patching at workspace level) also doesn't work with cargo projects depending on git (#4164):

wgpu = { git = "https://github.com/gfx-rs/wgpu", branch = "trunk" }

The above pulls in version 0.26 of metal, so wgpu fails to build.

@nical
Copy link
Contributor Author

nical commented Sep 22, 2023

Fixed in #4164

@nical nical closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants