Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wgpu.ico #4159

Closed
wants to merge 3 commits into from
Closed

Added wgpu.ico #4159

wants to merge 3 commits into from

Conversation

dcerisano
Copy link

Multipart favicon with resolutions from 16x16 to 256x256

Multipart favicon with resolutions from 16x16 to 256x256
@cwfitzgerald
Copy link
Member

I mean, this is neat, but why?

@dcerisano dcerisano requested a review from a team as a code owner September 21, 2023 20:32
Quantized (png compression) and palletized (256-colour pallette) wgpu.ico (now 24Kb)
@dcerisano
Copy link
Author

dcerisano commented Sep 21, 2023 via email

@Wumpf
Copy link
Member

Wumpf commented Sep 21, 2023

aren't 32x32 pngs how favicons are done these days? Overall leaning against adding this kind of resource to the repo if there's not a good reason: I wouldn't even encouraging the wgpu logo as a favicon like ever (except maybe for wgpu.rs): It's neat but not great at that size and why would you use that instead of what-ever else your website is about.
Like, thank god there's now webgl icon on shadertoy.com! 😄

@cwfitzgerald
Copy link
Member

Yeah, I'm going to say that, while an ico is useful in the general sense, it's doesn't really belong here. The wgpu logo is already in tree and can be used as a source for whatever uses people need.

@dcerisano
Copy link
Author

dcerisano commented Sep 21, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants