Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable vulkan presentation on Intel Mesa >= v21.2 #4110

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

flukejones
Copy link
Contributor

Due to an issue with Mesa versions less than 21.2 presentation on Vulkan was forced to Nvidia only. This in itself brought new issues around the Nvidia driver specfic format modifers.

As of Mesa 21.2 the Intel vulkan issue is fixed. This commit enables presentation on versions 21.2 and above for Intel.

References:

Closes #4101

Due to an issue with Mesa versions less than 21.2 presentation on Vulkan
was forced to Nvidia only. This in itself brought new issues around the
Nvidia driver specfic format modifers.

As of Mesa 21.2 the Intel vulkan issue is fixed. This commit enables
presentation on versions 21.2 and above for Intel.

References:
- NVIDIA/egl-wayland#72

Closes [gfx-rs#4101](gfx-rs#4101)

Signed-off-by: Luke D. Jones <[email protected]>
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was thinking at first the logic should be split so that we opt in the adapater, but that might too easily break future mesa version strings I reckon.
unfortunately I don't have a way to test this, trusting the version parsing works as intended

@Wumpf Wumpf enabled auto-merge (squash) September 5, 2023 14:05
@Wumpf Wumpf merged commit d17165f into gfx-rs:trunk Sep 5, 2023
20 checks passed
bradwerth pushed a commit to bradwerth/wgpu that referenced this pull request Sep 19, 2023
Due to an issue with Mesa versions less than 21.2 presentation on Vulkan
was forced to Nvidia only. This in itself brought new issues around the
Nvidia driver specfic format modifers.

As of Mesa 21.2 the Intel vulkan issue is fixed. This commit enables
presentation on versions 21.2 and above for Intel.

References:
- NVIDIA/egl-wayland#72

Closes [gfx-rs#4101](gfx-rs#4101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forced GPU selection prevents wgpu running on hybrid nvidia laptops
2 participants