Add get_mapped_range_as_array_buffer which - on wasm WebGPU builds - avoids copying mapped data into wasm heap (#4042) #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Sep 1, 2023
There was a problem hiding this comment.
Good minus changelog nit.
Will do the patch release after #4106 lands
CHANGELOG.md
Outdated
| @@ -92,6 +92,7 @@ By @fornwall in [#3904](https://github.com/gfx-rs/wgpu/pull/3904) and [#3905](ht | |||
|
|
|||
| - Empty scissor rects are allowed now, matching the specification. by @PJB3005 in [#3863](https://github.com/gfx-rs/wgpu/pull/3863). | |||
| - Add back components info to `TextureFormat`s. By @teoxoy in [#3843](https://github.com/gfx-rs/wgpu/pull/3843). | |||
| - Add `get_mapped_range_as_array_buffer` for faster buffer read-backs in wasm builds. By @ryankaplan in [#4042] (https://github.com/gfx-rs/wgpu/pull/4042). | |||
There was a problem hiding this comment.
This should be added to a 0.17.1 changelog
There was a problem hiding this comment.
Oh oops, I realize now that this should not have gone in 0.17. Moved to a section that I created for 0.17.1.
…avoids copying mapped data into wasm heap (gfx-rs#4042) Co-authored-by: Ryan Kaplan <[email protected]>
ryankaplan
commented
Sep 1, 2023
|
Oh, oops! I forgot to re-request review. I just did that. |
cwfitzgerald
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally landed in trunk here: 014ae3f
This PR is for a patch release :-)