-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming CommandEncoder::clearBuffer to CommandEncoder::fillBuffer #2174
Conversation
Thank you for taking a stab at this! So all that needs to be done here is exposing the method to wgpu-rs |
Ah, alright, I misread part of the discussions over gpuweb haha. |
We had it called |
Another thing is - this API should now be available without any features, previously it was behind a feature. |
oh cool didn't know that this is now in the spec. Nice! |
Alright, but does clear_texture remain under CLEAR_COMMANDS? Also, by gpuweb/gpuweb#2208 comment, |
yes, and we should rename it to CLEAR_TEXTURES, but I can do that later; going to make some changes to it anyways. |
6dbfe63
to
f25a45f
Compare
* fill_buffer does not require CLEAR_BUFFER feature
Okay, so I removed all the previous commits from this branch. They will still remain on my branch (https://github.com/UpsettingBoy/wgpu/tree/cmd-encoder-value) so when the spec adds @Wumpf I left CLEAR_COMMAND untouched for you to change. |
Connections
#2170
Description
This PR addsfill_buffer
to CommandEncoder for Vulkan and D3D12. Metal and GLES yet to be done (I cannot implement them 😢).There are probably some changes to be made, mainly in the d3d12 implementation. e.g There are no deallocations over the CPU only descriptor heap. Also, I think the changes I made for d3d12 FixedSizeHeap might be problematic on multi-threadingscenarios.
EDIT: For now is just a rename to keep up with the spec.
Testing
I only tested this PR with a small change to the
hello-compute
example. No other testing is done :(