Skip to content

Commit

Permalink
Skip AMD GPUs from RT Tests (#6728)
Browse files Browse the repository at this point in the history
  • Loading branch information
cwfitzgerald authored Dec 16, 2024
1 parent 286082a commit f384a72
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 12 deletions.
26 changes: 19 additions & 7 deletions tests/tests/ray_tracing/as_build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ use wgpu::{
util::{BufferInitDescriptor, DeviceExt},
*,
};
use wgpu_test::{fail, gpu_test, GpuTestConfiguration, TestParameters, TestingContext};
use wgpu_test::{
fail, gpu_test, FailureCase, GpuTestConfiguration, TestParameters, TestingContext,
};

struct AsBuildContext {
vertices: Buffer,
Expand Down Expand Up @@ -86,7 +88,9 @@ static UNBUILT_BLAS: GpuTestConfiguration = GpuTestConfiguration::new()
.parameters(
TestParameters::default()
.test_features_limits()
.features(wgpu::Features::EXPERIMENTAL_RAY_TRACING_ACCELERATION_STRUCTURE),
.features(wgpu::Features::EXPERIMENTAL_RAY_TRACING_ACCELERATION_STRUCTURE)
// https://github.com/gfx-rs/wgpu/issues/6727
.skip(FailureCase::adapter("AMD")),
)
.run_sync(unbuilt_blas);

Expand Down Expand Up @@ -114,7 +118,9 @@ static OUT_OF_ORDER_AS_BUILD: GpuTestConfiguration = GpuTestConfiguration::new()
.parameters(
TestParameters::default()
.test_features_limits()
.features(wgpu::Features::EXPERIMENTAL_RAY_TRACING_ACCELERATION_STRUCTURE),
.features(wgpu::Features::EXPERIMENTAL_RAY_TRACING_ACCELERATION_STRUCTURE)
// https://github.com/gfx-rs/wgpu/issues/6727
.skip(FailureCase::adapter("AMD")),
)
.run_sync(out_of_order_as_build);

Expand Down Expand Up @@ -184,10 +190,16 @@ fn out_of_order_as_build(ctx: TestingContext) {

#[gpu_test]
static OUT_OF_ORDER_AS_BUILD_USE: GpuTestConfiguration = GpuTestConfiguration::new()
.parameters(TestParameters::default().test_features_limits().features(
wgpu::Features::EXPERIMENTAL_RAY_TRACING_ACCELERATION_STRUCTURE
| wgpu::Features::EXPERIMENTAL_RAY_QUERY,
))
.parameters(
TestParameters::default()
.test_features_limits()
.features(
wgpu::Features::EXPERIMENTAL_RAY_TRACING_ACCELERATION_STRUCTURE
| wgpu::Features::EXPERIMENTAL_RAY_QUERY,
)
// https://github.com/gfx-rs/wgpu/issues/6727
.skip(FailureCase::adapter("AMD")),
)
.run_sync(out_of_order_as_build_use);

fn out_of_order_as_build_use(ctx: TestingContext) {
Expand Down
6 changes: 4 additions & 2 deletions tests/tests/ray_tracing/as_use_after_free.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use wgpu::{
Maintain, TlasInstance, TlasPackage, VertexFormat,
};
use wgpu_macros::gpu_test;
use wgpu_test::{GpuTestConfiguration, TestParameters, TestingContext};
use wgpu_test::{FailureCase, GpuTestConfiguration, TestParameters, TestingContext};

fn required_features() -> wgpu::Features {
wgpu::Features::EXPERIMENTAL_RAY_QUERY
Expand Down Expand Up @@ -147,6 +147,8 @@ static ACCELERATION_STRUCTURE_USE_AFTER_FREE: GpuTestConfiguration = GpuTestConf
.parameters(
TestParameters::default()
.test_features_limits()
.features(required_features()),
.features(required_features())
// https://github.com/gfx-rs/wgpu/issues/6727
.skip(FailureCase::adapter("AMD")),
)
.run_sync(acceleration_structure_use_after_free);
10 changes: 7 additions & 3 deletions tests/tests/ray_tracing/scene/mod.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use std::{iter, mem};

use wgpu_test::{gpu_test, GpuTestConfiguration, TestParameters, TestingContext};
use wgpu_test::{gpu_test, FailureCase, GpuTestConfiguration, TestParameters, TestingContext};

use wgpu::util::DeviceExt;

Expand Down Expand Up @@ -103,7 +103,9 @@ static ACCELERATION_STRUCTURE_BUILD_NO_INDEX: GpuTestConfiguration = GpuTestConf
.parameters(
TestParameters::default()
.test_features_limits()
.features(wgpu::Features::EXPERIMENTAL_RAY_TRACING_ACCELERATION_STRUCTURE),
.features(wgpu::Features::EXPERIMENTAL_RAY_TRACING_ACCELERATION_STRUCTURE)
// https://github.com/gfx-rs/wgpu/issues/6727
.skip(FailureCase::adapter("AMD")),
)
.run_sync(|ctx| {
acceleration_structure_build(&ctx, false);
Expand All @@ -114,7 +116,9 @@ static ACCELERATION_STRUCTURE_BUILD_WITH_INDEX: GpuTestConfiguration = GpuTestCo
.parameters(
TestParameters::default()
.test_features_limits()
.features(wgpu::Features::EXPERIMENTAL_RAY_TRACING_ACCELERATION_STRUCTURE),
.features(wgpu::Features::EXPERIMENTAL_RAY_TRACING_ACCELERATION_STRUCTURE)
// https://github.com/gfx-rs/wgpu/issues/6727
.skip(FailureCase::adapter("AMD")),
)
.run_sync(|ctx| {
acceleration_structure_build(&ctx, true);
Expand Down

0 comments on commit f384a72

Please sign in to comment.