Skip to content

Commit

Permalink
Tests for wgpu#4139. (#4148)
Browse files Browse the repository at this point in the history
  • Loading branch information
jimblandy authored Sep 17, 2023
1 parent 0ffdae3 commit f2bd557
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 0 deletions.
26 changes: 26 additions & 0 deletions tests/tests/query_set.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
use wgpu_test::{initialize_test, FailureCase, TestParameters};

#[test]
fn drop_failed_timestamp_query_set() {
let parameters = TestParameters::default()
// https://github.com/gfx-rs/wgpu/issues/4139
.expect_fail(FailureCase::always());
initialize_test(parameters, |ctx| {
// Enter an error scope, so the validation catch-all doesn't
// report the error too early.
ctx.device.push_error_scope(wgpu::ErrorFilter::Validation);

// Creating this query set should fail, since we didn't include
// TIMESTAMP_QUERY in our required features.
let bad_query_set = ctx.device.create_query_set(&wgpu::QuerySetDescriptor {
label: Some("doomed query set"),
ty: wgpu::QueryType::Timestamp,
count: 1,
});

// Dropping this should not panic.
drop(bad_query_set);

assert!(pollster::block_on(ctx.device.pop_error_scope()).is_some());
});
}
1 change: 1 addition & 0 deletions tests/tests/root.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ mod instance;
mod occlusion_query;
mod partially_bounded_arrays;
mod poll;
mod query_set;
mod queue_transfer;
mod resource_descriptor_accessor;
mod resource_error;
Expand Down

0 comments on commit f2bd557

Please sign in to comment.