refactor(dx12): remove unused root_signature arg. from `Device::cre…

…ate_command_signature`
gfx-rs · Sep 25, 2023 · 8e841b9 · 8e841b9
1 parent 5aed866
commit 8e841b9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/d3d12/src/device.rs b/d3d12/src/device.rs
@@ -291,7 +291,6 @@ impl Device {
 
     pub fn create_command_signature(
         &self,
-        root_signature: RootSignature,
         arguments: &[IndirectArgument],
         stride: u32,
         node_mask: NodeMask,
@@ -307,7 +306,7 @@ impl Device {
         let hr = unsafe {
             self.CreateCommandSignature(
                 &desc,
-                root_signature.as_mut_ptr(),
+                std::ptr::null_mut(),
                 &d3d12::ID3D12CommandSignature::uuidof(),
                 signature.mut_void(),
             )

diff --git a/wgpu-hal/src/dx12/device.rs b/wgpu-hal/src/dx12/device.rs
@@ -101,23 +101,20 @@ impl super::Device {
             cmd_signatures: super::CommandSignatures {
                 draw: raw
                     .create_command_signature(
-                        d3d12::RootSignature::null(),
                         &[d3d12::IndirectArgument::draw()],
                         mem::size_of::<wgt::DrawIndirectArgs>() as u32,
                         0,
                     )
                     .into_device_result("Command (draw) signature creation")?,
                 draw_indexed: raw
                     .create_command_signature(
-                        d3d12::RootSignature::null(),
                         &[d3d12::IndirectArgument::draw_indexed()],
                         mem::size_of::<wgt::DrawIndexedIndirectArgs>() as u32,
                         0,
                     )
                     .into_device_result("Command (draw_indexed) signature creation")?,
                 dispatch: raw
                     .create_command_signature(
-                        d3d12::RootSignature::null(),
                         &[d3d12::IndirectArgument::dispatch()],
                         mem::size_of::<wgt::DispatchIndirectArgs>() as u32,
                         0,