[wgsl-in] Miscellaneous cleanups to construction lowering #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
approved these changes
Oct 23, 2023
In `front:wgsl::lower::construct`, build `Components` values directly, rather than building a `ComponentsHandle` and then calling its `borrow` method.
jimblandy
force-pushed
the
construction-cleanups
branch
from
0b2ea11 to
de60a42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc fix for
Lowerer::constructor.Delete
ComponentsHandletype.In
front:wgsl::lower::construct, buildComponentsvalues directly,rather than building a
ComponentsHandleand then calling itsborrowmethod.Consolidate array and struct cases in construction.