Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validation reject 64-bit floating-point literals. #2567

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

jimblandy
Copy link
Member

Make expression validation and constant expression validation reject Literal expressions containing F64 literals unless the FLOAT64 capability is enabled.

Later changes will use `check_width` in new functions. Separating out
`WidthError` will make it easier to incorporate `check_width`'s
results into its new callers'.
Make expression validation and constant expression validation reject
`Literal` expressions containing `F64` literals unless the `FLOAT64`
capability is enabled.
@jimblandy jimblandy requested a review from a team as a code owner October 19, 2023 01:05
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teoxoy teoxoy merged commit 334f745 into gfx-rs:master Oct 19, 2023
5 checks passed
@jimblandy jimblandy deleted the reject-f64-literals branch October 22, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants