Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glsl/spv-out] Cull functions that should not be available for a given stage #2531

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Oct 3, 2023

fixes #2524

Done it for SPIR-V as well since the ability to separate entry points (#1329) was added to work around driver bugs and I can imagine them misbehaving in this case as well.

@teoxoy teoxoy requested a review from a team as a code owner October 13, 2023 16:22
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but see if the comments I suggested are right.

src/back/glsl/mod.rs Outdated Show resolved Hide resolved
@teoxoy teoxoy enabled auto-merge (squash) October 18, 2023 12:46
@teoxoy teoxoy merged commit e25280d into gfx-rs:master Oct 18, 2023
6 checks passed
@teoxoy teoxoy deleted the cull-functions branch October 18, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shader translation error, no function with name 'fwidth'
2 participants