Rename some ConstantEvaluator-associated types and values. #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Naming is hard 😅 Can we do |
`ExpressionConstnessTracker::contains` -> `is_const` `ConstantEvaluatorExtraData` -> `FunctionConstantInfo` `ConstantEvaluator::extra_data` -> `function_info`
jimblandy
force-pushed
the
const-evaluator-renames
branch
from
b066956 to
aab1542
Compare
teoxoy
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These names seem more informative. "Extra Data" is pretty noisy. "Info" is at least what Naga already uses for "Data collected about this other thing" (ModuleInfo, FunctionInfo, etc.).
ExpressionConstnessTracker::contains->is_constConstantEvaluatorExtraData->FunctionConstantInfoConstantEvaluator::extra_data->function_info