New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshots: convert_wgsl: Remove redundant cubeArrayShadow entry. #2514

Merged

teoxoy merged 1 commit into gfx-rs:master from jimblandy:snapshots-duplicates

Sep 28, 2023

Member

jimblandy commented Sep 26, 2023

The duplicate entry was introduced accidentally in #1845.

Member

teoxoy commented Sep 26, 2023

Can we remove the duplicate one (the one before binding-arrays)?. To keep the blame accurate.


          snapshots: convert_wgsl: Remove redundant cubeArrayShadow entry.

cf22c1d

The duplicate entry was introduced accidentally in gfx-rs#1845.

jimblandy force-pushed the snapshots-duplicates branch from 199764a to cf22c1d Compare

September 28, 2023 02:10

teoxoy approved these changes

View reviewed changes

teoxoy merged commit a17a93e into gfx-rs:master

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet