Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that only constant expressions are hoisted to initializers. #2497

Conversation

jimblandy
Copy link
Member

See comments in test for details.

@jimblandy jimblandy force-pushed the wgsl-in-test-non-const-initializers branch from f539708 to b0e6ae9 Compare September 20, 2023 23:25
Also, just use a single out variable for each type. rather than
introducing a new output variable for every test we add.
@jimblandy jimblandy force-pushed the wgsl-in-test-non-const-initializers branch from b0e6ae9 to f98b450 Compare September 20, 2023 23:59
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@teoxoy teoxoy merged commit 314585f into gfx-rs:const-expressions-2 Sep 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants