Prevent using multiple push constant variables in one entry point. #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyDev
force-pushed
the
prevent-multiple-push-constants
branch
from
41f112f to
38a391d
Compare
teoxoy
reviewed
Sep 18, 2023
andriyDev
force-pushed
the
prevent-multiple-push-constants
branch
from
38a391d to
a613fdd
Compare
andriyDev
commented
Sep 19, 2023
andriyDev
force-pushed
the
prevent-multiple-push-constants
branch
from
a613fdd to
168533b
Compare
andriyDev
force-pushed
the
prevent-multiple-push-constants
branch
from
168533b to
eaf4f42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using multiple push constant variables was undefined behavior (in wgpu, this resulted in gfx-rs/wgpu#4099). Now, multiple push constant variables per entry point is a validation error!