Skip to content

Commit

Permalink
snapshots: convert_spv: Don't validate the module twice.
Browse files Browse the repository at this point in the history
Remove the call to `Validator::validate` in `convert_spv`, since it
directly follows the call to `check_targets`, which also called
`Validator::validate`.

The only difference between the two is whether `Parameters::god_mode`
is respected, but this difference doesn't seem to have been
deliberate: at the time the call to `check_targets` was added to
`convert_spv` (5f21cf3, 2021-02-17), the two calls were exactly the
same.
  • Loading branch information
jimblandy committed Sep 24, 2023
1 parent 57bebbc commit 772f017
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions tests/snapshots.rs
Original file line number Diff line number Diff line change
Expand Up @@ -691,12 +691,6 @@ fn convert_spv(name: &str, adjust_coordinate_space: bool, targets: Targets) {
)
.unwrap();
check_targets(&mut module, name, targets, None);
naga::valid::Validator::new(
naga::valid::ValidationFlags::all(),
naga::valid::Capabilities::default(),
)
.validate(&module)
.unwrap();
}

#[cfg(feature = "spv-in")]
Expand Down

0 comments on commit 772f017

Please sign in to comment.