Getter methods for OpenConnectionArguments #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 86.14% 86.49% +0.35%
==========================================
Files 40 40
Lines 6560 6619 +59
==========================================
+ Hits 5651 5725 +74
+ Misses 909 894 -15 ☔ View full report in Codecov by Sentry. |
gftea
reviewed
Oct 14, 2024
The getters use a `get_` prefix, even though this is discouraged by the naming conventions (see Rust API guidelines). The reason is that setters are already present with the same name.
eglimi
force-pushed
the
eglimi/connection-getters
branch
from
e8c2118 to
eaaa469
Compare
gftea
approved these changes
Oct 14, 2024
|
@eglimi , thanks for contribution, merged |
gftea
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Add getter methods to OpenConnectionArguments. Closes #146 The getters use a `get_` prefix, even though this is discouraged by the naming conventions (see Rust API guidelines). The reason is that setters are already present with the same name. * Add tests for OpenConnectionArguments getters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getter methods have a
get_prefix, unlike what is suggested by the Rust API guidelines. The reason is that the names withoutget_is already used by setter methods.An alternative would be to make the fields public. This might be a better option in this case, because the fields can be changed by setters already anyway.
To make it consistent, it also adds a
scheme(...)setter.