Allow named groups in regex generation #62
Conversation
|
|
||
| ;; intersection unsupported for now | ||
| #_"[{&&[}{]}]"]) | ||
|
|
||
| (defspec generator-regression-spec (times 1000) | ||
| ;; TODO: make a prop in test.chuck that's like for |
There was a problem hiding this comment.
I replaced this with #61.
| (let [parsed {:type :group | ||
| :elements [alternation] | ||
| :flag group-flags} | ||
| [flag-header [flag-type flag-details]] group-flags] |
There was a problem hiding this comment.
For your reviewing comfort, when you have a NonCapturingMatch, group-flags looks like:
[:GroupFlags [:NonCapturingMatchFlags [:MatchFlagsExpr]]]When you have a NamedCapturingGroup, it looks like:
[:GroupFlags [:NamedCapturingGroup [:GroupName "x"]]]
There was a problem hiding this comment.
I think you changed the logic here so that #"foo(?i:bar)" is accepted, when it used to be :unsupported`. I'll edit it to use the full data structure check from the old version.
|
Is Circle not supposed to build my branch? |
|
I'm not sure how circle is configured; haven't gotten a PR in a while :) |
|
Anyhow this sounds straightforward; I'll probably take a closer look in the next couple days. Thanks! |
|
Unfortunately I've noticed that the tests (on master) are currently failing on my java 12. I wonder if there have been regex changes between java 8 and 12. Not the fault of this PR, obviously, but it makes it more of a pain to review. So I'm going to try to look into that as well. |
|
Apparently at least one of the new features is |
|
Also |
|
I just wrote up #63 to stand for the current build issues; I'd like to get that taken care of and then I'll come back to this. |
|
Woo boy, okay, I think this works now. Sorry for the delay. This whole thing is pretty complicated and that's what I get for deciding to do something pretty complicated. |
|
Released as version |
|
awesome, thanks! |
What it says on the tin. I hope.