Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OS-dependent PATH and COMMAND. #310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

puripuri2100
Copy link
Contributor

  • Remove OS-dependent PATH. (e.g. usr/local/share/satysfi)
  • Remove OS-dependent COMMAND. (e.g. cp)

The execution test is changed as follows1:

dune exec -- satysfi --version

dune exec -- satysfi demo/demo.saty -o demo/demo.pdf

Footnotes

  1. https://www.mankier.com/1/dune-exec

@puripuri2100
Copy link
Contributor Author

Failed the source code download? 🤔


[ERROR] Failed to get sources of biniou.1.2.1: curl error code 503

https://github.com/gfngfn/SATySFi/runs/4457510474?check_suite_focus=true#step:5:1625


#=== ERROR while fetching sources for result.1.5 ==============================#
OpamSolution.Fetch_fail("https://github.com/janestreet/result/releases/download/1.5/result-1.5.tbz (curl: code 503 while downloading https://github.com/janestreet/result/releases/download/1.5/result-1.5.tbz)")

#=== ERROR while fetching sources for ppx_deriving.5.2.1 ======================#
OpamSolution.Fetch_fail("https://github.com/ocaml-ppx/ppx_deriving/releases/download/v5.2.1/ppx_deriving-v5.2.1.tbz (curl: code 503 while downloading https://github.com/ocaml-ppx/ppx_deriving/releases/download/v5.2.1/ppx_deriving-v5.2.1.tbz)")

#=== ERROR while fetching sources for biniou.1.2.1 ============================#
OpamSolution.Fetch_fail("https://github.com/mjambon/biniou/releases/download/1.2.1/biniou-1.2.1.tbz (curl: code 503 while downloading https://github.com/mjambon/biniou/releases/download/1.2.1/biniou-1.2.1.tbz)")

https://github.com/gfngfn/SATySFi/runs/4457510474?check_suite_focus=true#step:5:5296

@leque
Copy link
Contributor

leque commented Dec 9, 2021

Some my thoughts:

  • I think it would be generally nice to reduce dependencies on Unix-specific commands. Should we remove dependencies on make and sh (to download fonts and install libs) too? (This might be done in separated PRs, though.)
  • satysfi.opam uses PREFIX make variable to customize the install location. Is it ok to discard this capabiilty?

@na4zagin3
Copy link
Contributor

I think it would be generally nice to reduce dependencies on Unix-specific commands. Should we remove dependencies on make and sh (to download fonts and install libs) too? (This might be done in separated PRs, though.)

At least we can have OPAM to download fonts like #149.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants