-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyproject.toml to update gevent #15
base: main
Are you sure you want to change the base?
Conversation
Pin [email protected] to [email protected] to fix ✗ Inconsistent Interpretation of HTTP Requests ('HTTP Request/Response Smuggling') (new) [High Severity][https://security.snyk.io/vuln/SNYK-PYTHON-GEVENT-5906371] in [email protected]
Merge? :) |
May be we can use latest gevent for all pythons? Not only 3.11 https://www.gevent.org/changelog.html
|
@skykistler The 3.11 test is still failing. Can you fix that some time soon? @spumer I'm generally in favour of using the latest versions, but the version specified in the dependencies is just the minimum version required, so you can use any later version as well, but some legacy projects might nevertheless be slow to upgrade. |
I think the CI failed initially because of an issue with the 23.9.0 gevent build, they made a patch release for it. But yeah there is also 23.9.1 now which we've been using. Ended up forking and rolling forward due to the CVE, up to you whether you'd like to merge. Maybe a minor release is warranted for the greenlet upgrade and leave v0.2.3 working for legacy folks @gfmio lmk your opinion! |
Any chance we can get this merged? @gfmio |
Just curious if someone in this thread knows: gevent uses calver instead of semver, which I think means the Poetry caret constraint limits the upper bound of gevent versions to releases within the same month. Would it maybe make sense to make the upper limit several months out at a time? Or within the same year? Not sure what the best practices around calver version constraints are |
Pin [email protected] to [email protected] to fix
✗ Inconsistent Interpretation of HTTP Requests ('HTTP Request/Response Smuggling') (new) [High Severity][https://security.snyk.io/vuln/SNYK-PYTHON-GEVENT-5906371] in [email protected]