-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve version name #1129
Improve version name #1129
Conversation
The version for flatpak comes from the appdata.xml file: https://github.com/getting-things-gnome/gtg/blob/master/data/org.gnome.GTG.appdata.xml.in.in I guess we could add a 0.7-dev version while we are working on a new release |
Oh cool, I'll have a look at that file! |
Hm it doesn't seem to be quite as simple as that. I tried adding But it always shows 0.6 when inside There may be a place to tell flatpak that this is a dev or snapshot version - I'll experiment. |
Ah OK, I tried building the flatpak locally and I got "F: Ignoring release element without timestamp or date", which would explain it. And indeed, adding But there must be more to it. To be sure, I added
to the XML. Building the flatpak locally with But pushing to a fork, triggering the workflow, downloading and installing the flatpak, still shows 0.6. I don't understand where it gets that 0.6 from I updated the PR with something that works locally, but I'll keep digging to find out what's wrong with the weekly flatpak. |
Update base version from 0.6.0 to 0.7-dev. The idea is that when we're ready to release 0.7, we'll create a 0.7 branch. We'll then update the version to "0.7" on that branch, and "0.8-dev" on master. Append the short commit hash in development mode (as before) Append the date when making a snapshot using flatpak, to help keep track of versions when using the weekly flatpak. Tested the flatpak by running the GHA workflow on my fork.
LGTM! Thanks, and yeah dev snapshot looks better |
Update base version from 0.6.0 to 0.7-dev.
The idea is that when we're ready to release 0.7, we'll create a 0.7 branch. We'll then update the version to "0.7" on that branch, and "0.8-dev" on master.
Append the short commit hash in development mode (as before)
Append the date in flatpak mode, to help keep track of versions when using the weekly flatpak. Tested the flatpak by running the GHA workflow on my fork.