Add builddeps sorting #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Troy Harvey <[email protected]>
|
Adding Joey and Silke as reviewers to ensure we have a sound strategy here. |
silkeh
requested changes
Feb 18, 2024
There was a problem hiding this comment.
This comment also applies here. Currently, this PR might cause ybump and yupdate to undo sorting changes made to appease the CI if I read it correctly.
As for the implementation: I'd prefer a solution where we expose the sorting in a Python module, and then import that in ybump, yupdate and the sorting script in the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add automatic sorting of builddeps to ybump and yupdate.
It was discovered that the bugs mentioned on Matrix with regards to package descriptions already occurs with ybump and yupdate anyway so there are no known new issues including this.
I think for workflow reasons this might still make sense to add as a optional go-task check.