Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accept header to HTTP requests #61

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add Accept header to HTTP requests #61

merged 1 commit into from
Dec 19, 2023

Conversation

ReillyBrogan
Copy link
Contributor

While debugging why netfilter.org was returning a 403 with the Solbuild client I noticed that wget (which succeeded) was sending the Accept: */* header. When I added it to Solbuild it started working. This header should be safe to send in all circumstances as it merely indicates that we're willing to accept any content-type (which we are).

While debugging why netfilter.org was returning a 403 with the Solbuild client I noticed that wget (which succeeded) was sending the `Accept: */*` header. When I added it to Solbuild it started working. This header should be safe to send in all circumstances as it merely indicates that we're willing to accept any content-type (which we are).

Signed-off-by: Reilly Brogan <[email protected]>
@ReillyBrogan ReillyBrogan added the backport-me Backport to stable release label Dec 19, 2023
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Contributor

@TraceyC77 TraceyC77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@TraceyC77 TraceyC77 merged commit e376f80 into master Dec 19, 2023
1 check passed
@TraceyC77 TraceyC77 deleted the add-accept-header branch December 19, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-me Backport to stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants