builder/source/simple: Disable compression when downloading artifacts #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generally causing more issues than it solves. It's usefulness is also pretty debatable when we're downloading pre-compressed artifacts. Resolves getsolus/packages#989.
joebonrichie
force-pushed
the
grab-disable-compression
branch
from
ae32fbf to
2b86832
Compare
|
It looks simple and straightforward, but I'd be inclined to hear Silke's opinion as well. |
silkeh
reviewed
Dec 11, 2023
Instead of initializing a default `NewClient()` Co-authored-by: Silke Hofstra <[email protected]>
joebonrichie
force-pushed
the
grab-disable-compression
branch
from
e6e14ad to
7e30196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally causing more issues than it solves. It's usefulness is also pretty debatable when we're downloading pre-compressed artifacts.
Resolves getsolus/packages#989.