Add installCommand to ypkg-install-deps invocation #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that ypkg uses either the default installCommand or the one that was passed in as an argument. Signed-off-by: Rune Morling <[email protected]>
1 task
|
Has been tested by staff via getsolus/packages#3850 and getsolus/packages#4063 for a week now. |
ermo
added a commit
to getsolus/packages
that referenced
this pull request
Nov 4, 2024
**Summary** - `eopkg.py2` now writes versioned (v3), gdbm format FilesDB shelves, and versioned LazyDB caches; both using Pickle Protocol Version 2. - `eopkg.py3/bin` now writes versioned (v4), gdbm format FilesDB shelves, and versioned LazyDB caches; both using Pickle Protocol Version 2. - FilesDB and LazyDBs are autoupgraded on version mismatch. - The output of `sudo eopkg.py2/py3/bin rdb` operations has been cleaned up significantly. - Taskfile now uses `eopkg.bin` for indexing operations due to the improved output it provides. - ypkg-install-deps supports an optional -e/--eopkg-cmd argument, which defaults to `eopkg.py3` (look at getsolus/solbuild#117 for how this will be leveraged in solbuild). This is intended to help make the transition between using `eopkg.py2` and `eopkg.py3/bin` much smoother. **Changelog** - [eopkg.py2 3.12.5](https://github.com/getsolus/eopkg/releases/tag/v3.12.5) - [eopkg.py3 4.1.5](https://github.com/getsolus/eopkg/releases/tag/v4.1.5) - [eopkg.py3 4.1.6](https://github.com/getsolus/eopkg/releases/tag/v4.1.6) **Test Plan** - Check out this branch - Clean out the local repo with `go-task clean-local` - Build pisi w/ `go-task localcp` and install it - Pay attention to any mentions of FilesDB rebuilds in subsequent build logs (e.g. eopkg, ypkg and whatever else you decide to build for testing purposes). In particular, pay attention to the `FilesDB (version:` part. - Build eopkg w/ `go-task localcp` and install it and its `python-eopkg` subpackage - Notice how after installing the updated eopkg, subsequent builds will now show a list of which packages are indexed in the local repo prior to the build. - Build ypkg w/ `go-task localcp` and install it - Follow the Test Plan in #3850 **Checklist** - [x] Package was built and tested against unstable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that ypkg uses either the default installCommand or the one that was passed in as an argument.