Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nuitka-compiled py3 eopkg.bin (except for when building old-style pspec.xml packages) #109

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

ermo
Copy link
Contributor

@ermo ermo commented Sep 12, 2024

In various tests, this is showing a speedup for install operations on the order of 20-25% (very noticeable for e.g. the ISO generation scripts).

This is also part of the preparation for dropping the py2 pisi package (which owns the eopkg symlink at the time of this writing).

Note that this will keep using eopkg.py2 for building old pspec.xml packages for now; switching to using the explicit version avoids solbuild having to rely on which package owns the eopkg symlink.

When the epoch happens and eopkg.py2 is dropped from the repo, BuildXML needs to be changed to use eopkg.py3.

@ermo ermo added the enhancement New feature or request label Sep 12, 2024
@ermo ermo force-pushed the switch-to-eopkg.bin branch from 2ac9acd to 291ce1e Compare September 12, 2024 21:33
@ermo ermo changed the title Use nuitka-compiled py3 eopkg.bin instead eopkg.py2 Use nuitka-compiled py3 eopkg.bin instead of eopkg.py2 Sep 12, 2024
@ermo ermo force-pushed the switch-to-eopkg.bin branch 3 times, most recently from 4f06cbc to 66ef1a8 Compare September 13, 2024 20:34
@ermo ermo changed the title Use nuitka-compiled py3 eopkg.bin instead of eopkg.py2 Use nuitka-compiled py3 eopkg.bin (except for when building old-style pspec.xml packages) Sep 13, 2024
@ermo ermo force-pushed the switch-to-eopkg.bin branch from 66ef1a8 to 0679db2 Compare September 16, 2024 19:19
In various tests, this is showing a speedup for install operations on the
order of 20-25% (very noticeable for e.g. the ISO generation scripts).

This is also part of the preparation for dropping the py2 pisi package
(which owns the `eopkg` symlink at the time of this writing).

Note that this will keep using `eopkg.py2` for building old pspec.xml
packages for now; switching to using the explicit version avoids
solbuild having to rely on which package owns the `eopkg` symlink.

When the epoch bump happens and eopkg.py2 is dropped from the repo,
BuildXML needs to be changed to use `eopkg.py3`.

Note that ypkg already rundeps on python-eopkg, which contains eopkg.py3.

Signed-off-by: Rune Morling <[email protected]>
@ermo ermo force-pushed the switch-to-eopkg.bin branch from 0679db2 to 36b4895 Compare September 16, 2024 19:21
@ermo ermo marked this pull request as ready for review September 16, 2024 19:22
Copy link
Contributor Author

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to admin merge this to master so we can begin testing the usage of eopkg.bin ahead of the epoch-related work.

@ermo ermo merged commit 7597402 into master Sep 16, 2024
1 check passed
@ermo ermo deleted the switch-to-eopkg.bin branch September 16, 2024 19:25
@silkeh silkeh added this to the 1.7.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants