Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] repo-wide: Use .yaml extension for monitoring files #4812

Merged
merged 2 commits into from
Jan 12, 2025
Merged

[NFC] repo-wide: Use .yaml extension for monitoring files #4812

merged 2 commits into from
Jan 12, 2025

Conversation

malfisya
Copy link
Member

@malfisya malfisya commented Jan 11, 2025 •
edited
Loading

Summary

Lowering friction between Solus and Serpent repo and make way for using boulder to automate adding monitoring files.

  • Use .yaml extension for monitoring files.
  • Replace all references to .yml with .yaml
  • Update CI accordingly
  • Update Taskfile accordingly

Test Plan

Checklist

  • [n/a ] Package was built and tested against unstable
  • [n/a] This change could gainfully be listed in the weekly sync notes once merged

@malfisya malfisya changed the title [NFC] repo-wide: Use .yaml extension for monitroing files [NFC] repo-wide: Use .yaml extension for monitoring files Jan 11, 2025
@malfisya
Copy link
Member Author

malfisya commented Jan 11, 2025 •
edited by davidjharder
Loading

Before landing, these need to be updated:

@davidjharder davidjharder mentioned this pull request Jan 12, 2025
Merged
@malfisya
Copy link
Member Author

malfisya commented Jan 12, 2025 •
edited
Loading

For separate task:
Should we add SPDX headers to these files ?These files are new and the contributors are easily contacted, if we want to license them properly.

Take it as practice before we take a plunge at relicensing package.yml.

#4814

@davidjharder
Copy link
Member

davidjharder commented Jan 12, 2025 •
edited
Loading

I added a second commit. So malfisya's first commit does all the renames, and mine does the rest

@davidjharder
[NFC] repo-wide: Replace montoring.yml with monitoring.yaml
ee3114d 
**Summary**

- Previous commit handled all the renames, this commit chnages:
- Comment text in some monitoring files
- The taskfile task for a new monitoring file
- The CI check for monitoring file existence
@malfisya malfisya marked this pull request as ready for review January 12, 2025 03:47
@malfisya malfisya requested a review from silkeh January 12, 2025 13:10
@malfisya
Copy link
Member Author

There is a CI edit, so asked Silke for review

silkeh
silkeh approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@silkeh silkeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidjharder
Copy link
Member

YOLO

@davidjharder davidjharder merged commit c193d2a into main Jan 12, 2025
3 checks passed
@davidjharder davidjharder deleted the yaml branch January 12, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silkeh silkeh silkeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Solus
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malfisya @davidjharder @silkeh