snapd: bugfix: Fix formatting error and change to critical #4668
+14
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Fix text to be two lines not three per spec Change urgency to critical so users must manually dismiss the notification to give them time to copy the link Resolves #4636
silkeh
requested changes
Dec 24, 2024
Comment on lines
+42
to
+43
| "Snaps will stop working in early January 2025. For details see<br> \ | ||
| ${URL}" |
There was a problem hiding this comment.
This doesn't work for me:
It also overflows the regular notification:
Maybe trim it down so at least help.getsol.us is visible:
Suggested change
| "Snaps will stop working in early January 2025. For details see<br> \ | |
| ${URL}" | |
| "Snaps will stop working in early January 2025. See ${URL}" |
Comment on lines
+32
to
+34
| # This prevents the warning from showing on KDE Plasma | ||
| # if [[ -n "${BAMF_DESKTOP_FILE_HINT+x}" ]] && [[ -n "${GIO_LAUNCHED_DESKTOP_FILE+x}" ]] | ||
|
|
There was a problem hiding this comment.
I would just remove this entirely if it doesn't work.
Suggested change
| # This prevents the warning from showing on KDE Plasma | |
| # if [[ -n "${BAMF_DESKTOP_FILE_HINT+x}" ]] && [[ -n "${GIO_LAUNCHED_DESKTOP_FILE+x}" ]] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix text to be two lines not three per spec
Change urgency to critical so users must manually dismiss the notification to give them time to copy the link
Resolves #4636
Test Plan
Ran the Spotify and Termius snaps from command line and App menu
Verified the correct warning appeared
Checklist