Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapd: Update confinement warning with a date #4632

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

davidjharder
Copy link
Member

@davidjharder davidjharder commented Dec 20, 2024

Summary

Sync Message:

The warning that pops up whenever you run a snap has been changed to include the sentence "Snaps will stop working in early January 2025." This is part of a process we started back in July to remove snap support from Solus; we wrote about our reasons for this in a blog post. The Help Center has a page with more details about the warning and what you can do if you have snaps installed. Most users will not have snaps installed, as Solus has usually recommended that third-party apps be installed from the Third Party section of the Solus Software Center or as Flatpaks.

Test Plan

  • Run a CLI snap, see changed warning
  • Graphical warning untested

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

**Summary**

- Add a sentence to the warning which runs for every snap, telling users that snaps will stop working soon.
- Part of #325
@ermo ermo requested a review from silkeh December 20, 2024 17:34
@TraceyC77
Copy link
Contributor

Tested this on my laptop - pass

  • Built and installed the eopkg from this PR
  • Started a snap from command line
  • Read output

Result: I saw the updated text, output is formatted correctly
This is the output

❯ git st
On branch snapd-warning
Your branch is up to date with 'origin/snapd-warning'.

❯ /snap/bin/spotify
WARNING: snap is running with partial confinement. Snaps will stop working in early January 2025. See https://help.getsol.us/docs/user/software/third-party/snap for details

Also installed termius and tested with that, also good.

Running any snap from the app menu produces no warning whatsoever. That's unrelated to this change, I'll file a separate issue for that.

Copy link
Contributor

@TraceyC77 TraceyC77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and testing passed.

@TraceyC77 TraceyC77 merged commit 3c7d987 into main Dec 20, 2024
1 check passed
@TraceyC77 TraceyC77 deleted the snapd-warning branch December 20, 2024 20:58
@davidjharder davidjharder added the Topic: Sync Notes This PR/Issue can be highlighted in sync notes label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Sync Notes This PR/Issue can be highlighted in sync notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants