Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibre: Remove unused appstream files & restore desktop files #4605

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

malfisya
Copy link
Member

Summary

  • We can only include one appstream metainfo per package, remove the other files
  • There is not much justification deleting additional desktop files, restore them

Resolves #1364

Test Plan

  • Verify the appstream generation with appstream-builder --packages-dir=. --include-failed -v
  • Test the package in Plasma VM

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged (Write an appropriate message in the Summary section)

**Summary**

- We can only include one appstream metainfo per package,  remove the other files
- There is not much justification deleting additional desktop files, restore them

Resolves #1364
Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane. Thanks very much for digging into this

@davidjharder davidjharder merged commit b298cc3 into main Dec 17, 2024
1 check passed
@davidjharder davidjharder deleted the calibre branch December 17, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Calibre has wacky appstream data
2 participants