Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/Hooks: Add support for 'Add at' and '[NFC]' commits #4019

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

joebonrichie
Copy link
Contributor

Summary

  • Add at for initial package inclusion
  • Non functional change when the package isn't rebuilt

Test Plan

  • Only NFC tested

Checklist

  • Package was built and tested against unstable

@joebonrichie joebonrichie force-pushed the prepare-commit-msg-add-at-nfc branch 4 times, most recently from b316ada to 635ae29 Compare October 9, 2024 12:33
@EbonJaeger EbonJaeger added the hacktoberfest-accepted This PR is accepted for Hacktoberfest label Oct 15, 2024
@ermo ermo added the Topic: Tooling Tools and scripts label Oct 20, 2024
@ermo ermo added this to the Solus 4.7 milestone Oct 20, 2024
**Summary**
- Set commit title to 'Add at v(...)` for initial package inclusion
- Add [NFC] before non functional changes when the package isn't rebuilt

Thank you to to @joebonrichie for implementing this.

Signed-off-by: Rune Morling <[email protected]>
@ermo ermo force-pushed the prepare-commit-msg-add-at-nfc branch from 635ae29 to a309f8d Compare October 20, 2024 15:54
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ermo ermo merged commit 4cbffac into main Oct 20, 2024
2 checks passed
@ermo ermo deleted the prepare-commit-msg-add-at-nfc branch October 20, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted This PR is accepted for Hacktoberfest Topic: Tooling Tools and scripts
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants