-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch mdns resolver #3767
Draft
silkeh
wants to merge
4
commits into
main
Choose a base branch
from
switch-mdns-resolver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Switch mdns resolver #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a couple of issues that cropped up when switching:
|
silkeh
force-pushed
the
switch-mdns-resolver
branch
from
September 8, 2024 17:35
140af50
to
3381f6f
Compare
ermo
reviewed
Sep 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The avahi, baselayout and samba changes look sane to me.
ermo
added
Topic: Platform Integration
Integration of various components within Solus
Topic: Plumbing
Core components
labels
Oct 20, 2024
**Summary** Add mDNS discovery definitions for use with systemd resolved as mDNS resolver.
**Summary** Disable by default in favour of systemd-resolved.
**Summary** - Enable mDNS resolving in systemd-resolved to replace avahi-daemon. - Reduce the mDNS timeout to within reasonable bounds.
silkeh
force-pushed
the
switch-mdns-resolver
branch
from
October 24, 2024 14:09
3381f6f
to
816a529
Compare
**Summary** Disable built-in mDNS announce as it conflicts with Avahi or systemd-resolved. Provide a systemd-resolved service definition so Solus devices can still be discovered.
silkeh
force-pushed
the
switch-mdns-resolver
branch
from
October 24, 2024 15:07
816a529
to
af369ea
Compare
I've dropped the baselayout change as that can't be updated, and it actually works with the current configuration. |
This is currently blocked on compatibility:
|
silkeh
added
Blocked: Upstream
This is an upstream issue.
Blocked: Other
This is blocked on something else
labels
Oct 24, 2024
TraceyC77
modified the milestones:
Solus 4.7 Software Centers, Installer, py3 work and bug fixes,
Solus 4.8 Epoch
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Blocked: Upstream
This is an upstream issue.
Topic: Platform Integration
Integration of various components within Solus
Topic: Plumbing
Core components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR switches to using
systemd-resolved
as the default resolver, replacingavahi-daemon
.Resolves #2443
Test Plan
Basic resolution:
KDE connect:
Resolution timeouts using
time getent hosts -s $service $host
against IPv4-only and IPv6-only hosts:mdns_minimal
mdns_minimal
resolve
resolve
Note that the increased delay seems mostly because systemd also uses jitter (up to 250 ms per request). This results in mDNS timeouts theoretically taking between 875 ms and 1625 ms. Realistically it's more around 1.5 s.
Checklist