Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usysconf-epoch: Finalise #3491

Merged
merged 9 commits into from
Aug 25, 2024
Merged

usysconf-epoch: Finalise #3491

merged 9 commits into from
Aug 25, 2024

Conversation

silkeh
Copy link
Member

@silkeh silkeh commented Aug 7, 2024

Summary

Finalise the usysconf-epoch script:

  • Run it through shellcheck.

  • Actually delete orphaned files after backup.

  • Add a CLI flag for testing in a VM without rebooting.

  • Special case kernel module dep/map files.

  • Add support for an eopkg flag file and an epoch flag file.

  • Show a message while the script runs:

    usysconf-progress-2024-08-07_18.49.56.mp4

Note that the epoch script depends on the work in getsolus/eopkg#78 and getsolus/eopkg#79. The script is behind feature flags (see below), so it is safe to merge.

Test Plan

Tested in a VM with various disk limits:

Profile MB/s IOPS Normal boot Script
Slow HDD 10 55 1min 57s 1min 0s
Fast HDD 100 150 56s 20s
SATA SSD 500 85.000 4s 1s

Enabled by editing /etc/sysconfig/epoch with:

I_UNDERSTAND_THAT_THIS_SCRIPT_CAN_BREAK_MY_SYSTEM=1
I_WANT_TO_TEST_THE_EPOCH_TRANSITION_WORKS=1

Checklist

  • Package was built and tested against unstable

@silkeh silkeh force-pushed the epoch-improvements branch 2 times, most recently from 17d345b to 3638c84 Compare August 7, 2024 16:47
@silkeh silkeh marked this pull request as ready for review August 7, 2024 16:55
@silkeh silkeh requested a review from ReillyBrogan August 8, 2024 20:21
@silkeh silkeh force-pushed the epoch-improvements branch from e9c96f1 to 2ed1696 Compare August 18, 2024 20:39
@EbonJaeger
Copy link
Member

This question may be out of scope for this PR, but if a user is experiencing an issue or slowness, is there actually anything that we can ask them or get them to provide to try to figure out why?

@silkeh
Copy link
Member Author

silkeh commented Aug 21, 2024

but if a user is experiencing an issue or slowness, is there actually anything that we can ask them or get them to provide to try to figure out why?

Yeah, the script logs what it's doing. If a user can retrieve the logs using boot rescue after the 10 minute timeout we can probably see if it's processing files that we didn't expect.

@silkeh silkeh force-pushed the epoch-improvements branch from 2ed1696 to afc7f95 Compare August 21, 2024 13:38
@silkeh
Copy link
Member Author

silkeh commented Aug 25, 2024

Merging this so I can follow it up in the next PR.

@silkeh silkeh merged commit 7f70897 into main Aug 25, 2024
3 checks passed
@silkeh silkeh deleted the epoch-improvements branch August 25, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants