Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memtest86plus: Add at v7.00 #3286

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

memtest86plus: Add at v7.00 #3286

wants to merge 1 commit into from

Conversation

ermo
Copy link
Contributor

@ermo ermo commented Jul 11, 2024

Summary

Could be useful to have in the default boot menu and on install media.

Test Plan

(None yet -- this PR is for soliciting feedback)

Checklist

  • Package was built and tested against unstable

Could be useful to have in the default boot menu and on install media.
@ermo ermo marked this pull request as draft July 11, 2024 01:13
@ermo ermo requested a review from silkeh July 11, 2024 01:17
@ermo
Copy link
Contributor Author

ermo commented Jul 11, 2024

@silkeh What are the odds we could add a memtest boot entry by default for systems with this package installed and for the ISOs?

The organisation on-disk of this is just a draft; I added what I thought might be pertinent for now, but this is by no means intended to be the finished article...

Copy link
Member

@silkeh silkeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the odds we could add a memtest boot entry by default for systems with this package installed and for the ISOs?

Should be doable. Especially on the ISO since that's a static config AFAIK.

builddeps :
- tree
build : |
pushd build32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need a 32-bit build?

install -Dm00755 build32/memtest.efi ${TARGET}/build32/memtest.efi
install -Dm00755 build64/memtest.bin ${TARGET}/build64/memtest.bin
install -Dm00755 build64/memtest.efi ${TARGET}/build64/memtest.efi
cp -v README.md ${TARGET}/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the readme?

install -Dm00755 build64/memtest.bin ${TARGET}/build64/memtest.bin
install -Dm00755 build64/memtest.efi ${TARGET}/build64/memtest.efi
cp -v README.md ${TARGET}/
cp -vR grub ${TARGET}/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should either install grub/grub-legacy.cfg into /etc/grub.d/20_memtest86+, or we shouldn't provide them at all and let CBM handle it.

I'm not familiar enough with the grub side of CBM to know what the correct decision is here, so let's just omit this directory for now.

Comment on lines +30 to +31
install -Dm00755 build64/memtest.bin ${TARGET}/build64/memtest.bin
install -Dm00755 build64/memtest.efi ${TARGET}/build64/memtest.efi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine for now:

Suggested change
install -Dm00755 build64/memtest.bin ${TARGET}/build64/memtest.bin
install -Dm00755 build64/memtest.efi ${TARGET}/build64/memtest.efi
install -Dm00755 build64/memtest.bin ${TARGET}/memtest.bin
install -Dm00755 build64/memtest.efi ${TARGET}/memtest.efi

@silkeh silkeh self-assigned this Aug 18, 2024
@ermo ermo added Type: Feature Something can be enhanced. Topic: Platform Integration Integration of various components within Solus labels Oct 20, 2024
@ermo ermo added this to the Solus 4.7 milestone Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Platform Integration Integration of various components within Solus Type: Feature Something can be enhanced.
Projects
Status: Ready
Development

Successfully merging this pull request may close these issues.

2 participants