Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ignore list to the appstream checker script #3120

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

sheepman4267
Copy link
Member

@sheepman4267 sheepman4267 commented Jun 29, 2024

Summary

This PR gives the appstream progress checker the ability to ignore a list of packages, which is provided by common/Scripts/appstream_ignored_packages.txt. It also contains a starting point for that list of ignored packages.

Test Plan

  1. Run go-task check-appstream-progress within the repo.
  2. Make note of how many packages are reported as needing appstream data.
  3. Check out this PR.
  4. Run go-task check-appstream-progress again.
  5. Note the abrupt decrease in packages reported as needing appstream data.

**Summary**
With this commit, the appstream checker can now ignore packages based on common/scripts/appstream_ignored_packages.txt.
**Summary**
Result of a quick pass of the current appstream progress report; ignoring obvious low-hanging fruit and providing an example of ignore file format.
@sheepman4267 sheepman4267 marked this pull request as ready for review June 29, 2024 03:30
Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. Thanks!

@malfisya malfisya merged commit accf04e into main Jul 1, 2024
2 checks passed
@davidjharder davidjharder deleted the appstream-checker-ignorelist branch July 19, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants