Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/Scripts: Add a tool to check appstream metainfo progress #2981

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

sheepman4267
Copy link
Member

Summary
Adds a script to common which generates a report of packages shipping .desktop files, and how many of those are missing appstream metadata. The script can also scan a single pspec.xml. In this usage, it returns 0 if the package is correct (either ships no .desktop file or both a .desktop and appstream metadata), and returns 1 if the package ships only a .desktop file.

Fixes #2394

Test Plan

Test both use cases of the script. The full report is ./check_appstream_progress.py ../../packages (assuming you are in common/Scripts. An example of (at this time) packages to test the single-package use case are vlc (correct) and puddletag (incorrect).

Checklist

  • Package was built and tested against unstable

@sheepman4267 sheepman4267 force-pushed the appstream-checker-tool branch 2 times, most recently from b001f29 to d226142 Compare June 15, 2024 03:23
…e repository

**Summary**
Usage of the script is documented in its --help.
Fixes #2394
@sheepman4267 sheepman4267 force-pushed the appstream-checker-tool branch from d226142 to 9af5a49 Compare June 15, 2024 03:26
Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you for working on this. Cheers!

@sheepman4267 sheepman4267 merged commit 6e6740d into main Jun 15, 2024
2 checks passed
@sheepman4267 sheepman4267 deleted the appstream-checker-tool branch June 15, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants